RFR: 8087555: [ChoiceBox] uncontained value not shown

Kevin Rushforth kcr at openjdk.java.net
Tue Apr 21 12:19:11 UTC 2020

On Mon, 20 Apr 2020 12:23:16 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> The issue is that ChoiceBoxSkin
> a) doesn't update the text of the label if the value is not contained in the items
> b) doesn't respect converter for label text
> Fixed by
> - listening to value changes to update the label
> - removing ad-hoc updates (not needed), added update on converter change
> - passing all label updates through converter
> Added test for text updates that failed before the fix and pass after (note: there were no tests for the display text,
> so for coveragy, contains also tests that passed before as well as after)

@aghaisas @arapte can you review?


PR: https://git.openjdk.java.net/jfx/pull/191

More information about the openjfx-dev mailing list