[Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

Kevin Rushforth kcr at openjdk.java.net
Wed Apr 22 00:01:03 UTC 2020

On Sun, 19 Apr 2020 09:34:00 GMT, Jesper Skov <github.com+2720909+jskov at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/ToggleButton.java line 196:
>>> 195:     private ObjectProperty<ToggleGroup> toggleGroup;
>>> 196:     @Override
>>> 197:     public final void setToggleGroup(ToggleGroup value) {
>> This is unrelated to the fix. The changes in this file should be reverted.
> OK.  They are gone.
> Would this (keeping the changes very specific to the bug?) be worth mentioning in CONTRIBUTING.md?
> That is, like the note about imports: do not fix warnings that are not directly related to the issue?

Good idea. I'll add that to my growing list of things to improve in CONTRIBUTING.md.


PR: https://git.openjdk.java.net/jfx/pull/167

More information about the openjfx-dev mailing list