[Rev 01] RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

Florian Kirmaier fkirmaier at openjdk.java.net
Wed Apr 22 11:29:16 UTC 2020

On Fri, 17 Apr 2020 12:06:05 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>>   JDK-8241840
>>   Some code cleanups
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleWindowManager.java line 124:
>> 123:         int index = getWindowIndex(window);
>> 124:         if (index != -1 && window.isVisible()) {
>> 125:             focusedWindow = window;
> This change is sufficient for the test to pass, are there any other scenarios for which the changes in Window.java are
> needed. If so could you please add the relevant tests.

You are correct. The change happened, because of the leak for first noticeable in the Window class. I've now removed
the change from the Window class because it's not required.


PR: https://git.openjdk.java.net/jfx/pull/153

More information about the openjfx-dev mailing list