[Rev 01] RFR: 8241737: TabPaneSkin memory leak on replacing selectionModel
kcr at openjdk.java.net
Wed Apr 22 23:11:30 UTC 2020
On Wed, 15 Apr 2020 10:52:26 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> `TabPaneSkin` adds a listener to `SelectionModel.selectedItemProperty()` which holds the `SelectionModel` from being
>> GCed. Fix is to add and remove the listener when a `SelectionModel` is changed.
>> If the fix looks good, We can change all the `getSkinnable().getSelectionModel()` calls to use the new class member
>> The fix seems safe to cause any regression. Enabled an ignored test that was added as part of fix for
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
> Add tests
Marked as reviewed by kcr (Lead).
More information about the openjfx-dev