[Rev 01] RFR: 8175358: Memory leak when moving MenuButton into another Scene

Ambarish Rapte arapte at openjdk.java.net
Tue Apr 28 04:40:06 UTC 2020

On Mon, 27 Apr 2020 12:35:11 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
>> Root cause : When a MenuItem is removed from a Scene, if any accelerator has been set on MenuItem, it does not get
>> removed from Scene's list of accelerators.
>> Fix : If Scene changes for a Menu, remove the registered accelerators from Scene.
>> Testing : Added a unit test that fails before the fix and passes with it.
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>   spelling_correction

Looks good to me.


Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/199

More information about the openjfx-dev mailing list