RFR: 8087555: [ChoiceBox] uncontained value not shown

Ajit Ghaisas aghaisas at openjdk.java.net
Tue Apr 28 07:11:26 UTC 2020

On Mon, 27 Apr 2020 11:19:33 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> The issue is that ChoiceBoxSkin
>> a) doesn't update the text of the label if the value is not contained in the items
>> b) doesn't respect converter for label text
>> Fixed by
>> - listening to value changes to update the label
>> - removing ad-hoc updates (not needed), added update on converter change
>> - passing all label updates through converter
>> Added test for text updates that failed before the fix and pass after (note: there were no tests for the display text,
>> so for coveragy, contains also tests that passed before as well as after)
> Marked as reviewed by arapte (Reviewer).

The fix is OK.

Test file header should have year 2020 and not 2019.


PR: https://git.openjdk.java.net/jfx/pull/191

More information about the openjfx-dev mailing list