[Rev 01] RFR: 8087555: [ChoiceBox] uncontained value not shown

Jeanette Winzenburg fastegal at openjdk.java.net
Tue Apr 28 09:38:56 UTC 2020

> The issue is that ChoiceBoxSkin
> a) doesn't update the text of the label if the value is not contained in the items
> b) doesn't respect converter for label text
> Fixed by
> - listening to value changes to update the label
> - removing ad-hoc updates (not needed), added update on converter change
> - passing all label updates through converter
> Added test for text updates that failed before the fix and pass after (note: there were no tests for the display text,
> so for coveragy, contains also tests that passed before as well as after)

Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:

  fixed copyright year


  - all: https://git.openjdk.java.net/jfx/pull/191/files
  - new: https://git.openjdk.java.net/jfx/pull/191/files/e7f9e398..9b9a28a9

 - full: https://webrevs.openjdk.java.net/jfx/191/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/191/webrev.00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/191.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/191/head:pull/191

PR: https://git.openjdk.java.net/jfx/pull/191

More information about the openjfx-dev mailing list