RFR: 8242505: Some WebKit tests might fail because Microsoft libraries are not loaded
ghb at openjdk.java.net
Tue Apr 28 15:13:39 UTC 2020
On Wed, 22 Apr 2020 18:07:09 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> This PR will allow javafx.web unit tests to run to completion and pass on Windows with Visual Studio 2019.
> Two of the WebKit tests load the native WebKit library without initializing the JavaFX runtime. This will lead to test
> failures and will hang the test run if those tests are run before the other tests, and if the system doesn't have all
> the needed runtime libraries. The simple fix is to call the Toolkit method to load those libraries. This is only
> needed for unit tests that don't already initialize the JavaFX runtime (e.g., by calling `Platform::startup` or
> `Application::launch`) and call internal methods that execute native code as part of the test.
Looks good to me
Marked as reviewed by ghb (Reviewer).
More information about the openjfx-dev