RFR: 8241999: ChoiceBox: incorrect toggle selected for uncontained

Jeanette Winzenburg fastegal at openjdk.java.net
Tue Apr 28 15:42:55 UTC 2020

The issue is that the toggles is not reliably unselected if an uncontained value is set.

The root is ChoiceBoxSelectionModel which doesn't update the index on selecting an uncontained item, in particular it
fails to keep the invariant:

     assertEquals(getItems().indexOf(selectedItem), selectedIndex);

The fix here is to override select(item) to guarantee the assert.

Added/removed ignore from tests that failed before and pass after the fix. All other tests are passing before and after.


Commit messages:
 - 8241999: ChoiceBox: incorrect toggle selected for uncontained

Changes: https://git.openjdk.java.net/jfx/pull/200/files
 Webrev: https://webrevs.openjdk.java.net/jfx/200/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8241999
  Stats: 55 lines in 2 files changed: 44 ins; 7 del; 4 mod
  Patch: https://git.openjdk.java.net/jfx/pull/200.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/200/head:pull/200

PR: https://git.openjdk.java.net/jfx/pull/200

More information about the openjfx-dev mailing list