[jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]

Nir Lisker nlisker at openjdk.java.net
Fri Aug 7 13:09:12 UTC 2020

On Fri, 7 Aug 2020 12:48:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>>   Corrected NumberFormat constructor text
> modules/javafx.base/src/main/java/javafx/util/converter/CurrencyStringConverter.java line 35:
>> 34: /**
>> 35:  * A {@link StringConverter} implementation for {@link Number} values that represent currency. Instances of this
>> class are immutable. 36:  *
> Given that there are no setters or other mutator methods, the immutability seems obvious. I don't see a problem with
> stating it explicitly, though. It's up to you.

True, but I just looked at [Border](https://openjfx.io/javadoc/14/javafx.graphics/javafx/scene/layout/Border.html)
which states immutability, so I did the same. I don't mind changing it.


PR: https://git.openjdk.java.net/jfx/pull/277

More information about the openjfx-dev mailing list