Integrated: 8249777: build.gradle: project.version should not contain time stamps
kcr at openjdk.java.net
Mon Aug 10 12:37:39 UTC 2020
On Wed, 22 Jul 2020 17:22:25 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> The addMavenPublication method sets the `project.version` to `$MAVEN_VERSION`, where project is base, graphics,
> controls, etc. When doing an ordinary "developer" build, this property contains the time stamp . This is causing
> problems with the NetBeans gradle plugin not being able to determine the dependencies between the projects (modules).
> We haven't noticed this bug before now, because we suppress the creation of the individual project jar files, but if we
> were creating them, we would have the problem that each time we ran gradle, it would generate a new
> `project-$version.jar` file with a different time stamp each time the build was run. The setting of
> `project.version=$MAVEN_VERSION` is only used by the maven "publish" tasks, which isn't done for developer builds nor
> for most productions builds. The proposed solution is to add a new boolean `MAVEN_PUBLISH` flag, which will default to
> `false`. This flag will qualify the setting of the `MAVEN_VERSION` property and the configuration of the maven
> publishing tasks. After this change, it will be necessary to run gradle with `-PMAVEN_PUBLISH=true` in order to run the
> maven publishing tasks.
This pull request has now been integrated.
Author: Kevin Rushforth <kcr at openjdk.org>
Stats: 11 lines in 1 file changed: 1 ins; 9 del; 1 mod
8249777: build.gradle: project.version should not contain time stamps
Reviewed-by: sykora, jvos
More information about the openjfx-dev