RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false

Kevin Rushforth kcr at openjdk.java.net
Thu Aug 13 16:40:07 UTC 2020

On Thu, 13 Aug 2020 12:37:11 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.

This looks good based on my initial testing, including a modified version of the test program that doesn't temporarily
set resizable to true. Nice.

I want to do some additional testing.

I left one minor comment on the code formatting inline.

modules/javafx.graphics/src/main/native-glass/mac/GlassWindow+Java.m line 100:

> 99:             type = com_sun_glass_events_WindowEvent_MINIMIZE;
> 100:         } else if([self->nsWindow isZoomed]) {
> 101:             type = com_sun_glass_events_WindowEvent_MAXIMIZE;

Minor: can you add a space between `if` and `(` to match our coding style?


PR: https://git.openjdk.java.net/jfx/pull/280

More information about the openjfx-dev mailing list