RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v2]
kcr at openjdk.java.net
Thu Aug 13 18:13:45 UTC 2020
On Thu, 13 Aug 2020 17:09:43 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
>> This looks good based on my initial testing, including a modified version of the test program that doesn't temporarily
>> set resizable to true. Nice.
>> I want to do some additional testing.
>> I left one minor comment on the code formatting inline.
> Thank you for the very quick feedback!
> In the application, the fix was developed for, it also seems to fix all issues related to iconified.
You may have seen my comment in JBS: This PR also fixes
[JDK-8249202](https://bugs.openjdk.java.net/browse/JDK-8249202), which I discovered while testing
[JDK-8248490](https://bugs.openjdk.java.net/browse/JDK-8248490). This means that I already have an automated test that
can be modified to test this. I just need to add a couple things to it (an assertion check for the iconified property,
a check to ensure that we can deiconify the stage, and then add a mode to run it with a non-resizable stage). Once I
verify it, I can send you the patch for the test, if that's OK with you?
More information about the openjfx-dev