RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v3]

Florian Kirmaier fkirmaier at openjdk.java.net
Thu Aug 13 19:45:49 UTC 2020

On Thu, 13 Aug 2020 19:21:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> You may have seen my comment in JBS: This PR also fixes
>> [JDK-8249202](https://bugs.openjdk.java.net/browse/JDK-8249202), which I discovered while testing
>> [JDK-8248490](https://bugs.openjdk.java.net/browse/JDK-8248490). This means that I already have an automated test that
>> can be modified to test this. I just need to add a couple things to it (an assertion check for the iconified property,
>> a check to ensure that we can deiconify the stage, and then add a mode to run it with a non-resizable stage). Once I
>> verify it, I can send you the patch for the test, if that's OK with you?
> Here is [the patch](https://github.com/openjdk/jfx/files/5071008/icontest.patch.txt) for
> [IconifyTest.java](https://github.com/openjdk/jfx/blob/1f42cebed04d88998d1a66ce99ba3c51995a18a8/tests/system/src/test/java/test/robot/javafx/stage/IconifyTest.java)
> :  [icontest.patch.txt](https://github.com/openjdk/jfx/files/5071008/icontest.patch.txt)
> I verified that it catches the bugs, in that the modified test fails without the fix and passes with the fix.
> Can you apply the patch to your repo and push a new commit with the updated test?

I've added your patch for the unit-test!
Nice to see it fixes more bugs. : )
Don't want to know how many hours were spent working around this bug by all the people around the world.
Compared to this, the fix was developed really quickly.


PR: https://git.openjdk.java.net/jfx/pull/280

More information about the openjfx-dev mailing list