RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v6]

Ambarish Rapte arapte at openjdk.java.net
Wed Aug 26 10:23:36 UTC 2020

On Tue, 25 Aug 2020 13:58:43 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>>   change approach from removing to excluding
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java line 1536:
>> 1535:         assertEquals(4, sm.getSelectedItems().size());
>> 1536:
>> 1537:         sl.dispose();
> wondering about these repeated blocks? The flow is single: (default on start) -> multiple -> single -> multiple. Looks
> like the last two are repeating the first two .. what do I overlook?

I had kept it with initial version of patch to test the listeners, But the patch has evolved to be very different now.
But still have removed only one block. Now there are three blocks and `sm.getSelectedItems().size()` varies in each

> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java line 181:
>> 180:
>> 181:     @Test public void test_SwitchingSelectionModel() {
>> 182:         ListView<String> listView = new ListView<>();
> maybe the name could be improved by adding _what_ it's testing: something like testCtrlAWhenSwitchingSelectionModel?

Done, removed _ from all the test names.


PR: https://git.openjdk.java.net/jfx/pull/172

More information about the openjfx-dev mailing list