RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina
jvos at openjdk.java.net
Thu Dec 3 16:33:56 UTC 2020
On Thu, 3 Dec 2020 13:58:31 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Thanks for checking. I'll remove the debug print statements, turn off verbose logging, and send it out for review. I would appreciate a thorough review of the code. Given the way JavaFX initializes the macOS application and sets the system menu bar, this seems like the least intrusive and least risky fix, but it would be nice if we can find a better fix that isn't overly complicated or risky.
> For some reason, the GitHub actions test results weren't added by the Skara bot. I filed [SKARA-839](https://bugs.openjdk.java.net/browse/SKARA-839) to track this.
> You can [click here](https://github.com/kevinrushforth/jfx/actions/runs/398484208) to see the results of the GitHub action for the most recent commit I pushed.
I added a few comments. In general, the approach looks ok to me. My comments are about edge cases, for which I'm not sure how we need to handle them.
More information about the openjfx-dev