RFR: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin [v3]

Ambarish Rapte arapte at openjdk.java.net
Mon Dec 7 13:03:17 UTC 2020

On Mon, 7 Dec 2020 10:46:32 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> issues with behavior:
>> - memory leak due to an key eventHandler that's not removed
>> - after dispose, still modifying treeView (anchor) state due to listeners selection that are not removed
>> issues with skin:
>> - memory leak due to behavior leaking
>> - memory leak due to cellFactory in flow not removed
>> - throws NPE after switching (on modifying root children, refresh) due to listeners not removed
>> Fixed by cleaning up as needed. Added tests that are failing before and passing after the fix.
> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>   rename for consistency

Marked as reviewed by arapte (Reviewer).


PR: https://git.openjdk.java.net/jfx/pull/358

More information about the openjfx-dev mailing list