[Rev 01] RFR: 8217472: Add attenuation for PointLight
nlisker at openjdk.java.net
Fri Jan 3 19:36:45 UTC 2020
On Fri, 3 Jan 2020 09:21:32 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java line 64:
>> 64: private double ca = DEFAULT_CA;
> The coefficients are not directly used in any arithmetic on java side. They are converted to `float` and passed to GL or D3D pipeline. Should these be `float `instead of `double` ?
I was wondering about it myself, but all the other values are `double`s that are cast to `float`s. Wouldn't it also be odd to have the API properties `DoubleProperty` and the peer to use `float`s? Isn't it just a matter of where the cast happens?
More information about the openjfx-dev