[Rev 01] RFR: 8217472: Add attenuation for PointLight
nlisker at openjdk.java.net
Fri Jan 3 19:41:15 UTC 2020
On Fri, 3 Jan 2020 09:25:21 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
> modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 175:
>> 174: lightsAttenuation[a++] = lights[i].attenuation;
>> 175: lightsAttenuation[a++] = 0;
> In the initial commit this filed was used for `maxRange`. I think that was good idea. Was there any issue with that approach ?
`maxRange` has its own array to reserve space for `minRange` if we ever do that (see [this discussion](https://github.com/javafxports/openjdk-jfx/issues/256#issuecomment-469970201)), so I future-proofed it.
More information about the openjfx-dev