[Rev 02] RFR: 8217472: Add attenuation for PointLight

Nir Lisker nlisker at openjdk.java.net
Fri Jan 3 23:03:05 UTC 2020

On Fri, 3 Jan 2020 22:37:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I have added few comments, but have not run tests and sample yet.
>> I still need to test your sample app on Mac.
> I get the error with your sample app. It fails on Mac or Linux (Ubuntu 16.04) with the same error as I reported above.

The error was for the cases of 2 and 3 lights (I was testing 1) and should be fixed now. My fault with copy-paste... that's why we use loops, but I guess this is some optimization for the pipeline. I wonder if it's really woth it over a single shader looping over the number of lights like d3d does.


PR: https://git.openjdk.java.net/jfx/pull/43

More information about the openjfx-dev mailing list