[Rev 03] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

Guru Hb ghb at openjdk.java.net
Mon Jan 6 04:32:35 UTC 2020

On Mon, 6 Jan 2020 04:32:34 GMT, Arun Joseph <ajoseph at openjdk.org> wrote:

>> Issue: Native part of WebView throws a DOMException and then, continues executing the rest of the function assuming that value is present. This causes the JVM to crash when retrieving the value.
>> Fix: Return from the function if exception was raised (code is similar to exception handling in [WebKitLegacy/java/DOM/JavaTreeWalker.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM/JavaTreeWalker.cpp))
>> This fix also needs to be applied to all function calls in [WebKitLegacy/java/DOM](https://github.com/openjdk/jfx/tree/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM) functions which raises DOMError similar to createAttributeImpl().
> The pull request has been updated with 1 additional commit.

+1, Looks good to me.


Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/47

More information about the openjfx-dev mailing list