RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface

Ambarish Rapte arapte at openjdk.java.net
Thu Jan 9 16:20:36 UTC 2020

On Fri, 3 Jan 2020 23:50:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Hi Johan, I did miss to verify this angle.
>> But have checked the code now and can confirm that, in a given function for all possible calls to `setMemErrorFlag()` there exists a call to `readAndClearMemErrorFlag()` in the same function. So it looks safe to remove the memory checks from `dispose()`
> I also looked at the code and don't see any mismatches (including those called from the `ACQUIRE_SURFACE` macro). I suppose you could restore the call, but since we are in a disposer thread throwing an exception doesn't seem like the right thing to do. You could log the error, but if we are sure there can be no pending errors, it might not be worth the effort.

Yes Kevin, After looking at the code it can be concluded that there are no mismatches. So It seems good to remove those checks. But just in case of safety can keep those as logs too.


PR: https://git.openjdk.java.net/jfx/pull/66

More information about the openjfx-dev mailing list