RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface
kcr at openjdk.java.net
Fri Jan 10 00:19:55 UTC 2020
On Thu, 9 Jan 2020 16:20:19 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> I also looked at the code and don't see any mismatches (including those called from the `ACQUIRE_SURFACE` macro). I suppose you could restore the call, but since we are in a disposer thread throwing an exception doesn't seem like the right thing to do. You could log the error, but if we are sure there can be no pending errors, it might not be worth the effort.
> Yes Kevin, After looking at the code it can be concluded that there are no mismatches. So It seems good to remove those checks. But just in case of safety can keep those as logs too.
I don't have a strong preference. Either removing the checks or leaving them in (with a log message rather than an exception) is fine with me.
More information about the openjfx-dev