RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5
kcr at openjdk.java.net
Tue Jan 14 12:16:29 UTC 2020
On Tue, 14 Jan 2020 12:12:37 GMT, Guru Hb <ghb at openjdk.org> wrote:
>> As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here).
>> The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped.
> +1, Looks good to me.
@effad - The extra commits and merge are no problem, provided that you want to get this into openjfx15.
However, if you intend to get this into openjfx14, as currently targeted in JBS, then you will need to:
1. Rebase your `JDK-8236912` branch on top of the upstream `jfx14` branch
2. Force-push your branch: `git push --force origin JDK-8236912`
3. Edit this PR and change the target to the `jfx14` branch
More information about the openjfx-dev