[Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5
rlichten at openjdk.java.net
Tue Jan 14 12:56:47 UTC 2020
On Tue, 14 Jan 2020 12:40:16 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> @effad - The extra commits and merge are no problem, provided that you want to get this into openjfx15.
>> However, if you intend to get this into openjfx14, as currently targeted in JBS, then you will need to:
>> 1. Rebase your `JDK-8236912` branch on top of the upstream `jfx14` branch
>> 2. Force-push your branch: `git push --force origin JDK-8236912`
>> 3. Edit this PR and change the target to the `jfx14` branch
> NOTE that this PR is not yet ready for integration. In addition to needing one more reviewer (me), there is the open question of which branch it should be targeted to.
> @effad I think that this should go into openjfx14, so the above steps I listed will allow for this.
> @guruhb can you please cancel your review (click the "re-request review" icon next to your review) until the above is done?
I've rebased my branch like this:
git fetch upstream
git rebase upstream/jfx14
and changed the base branch of this PR to jfx14. Hope that was the correct way to do this ;-).
More information about the openjfx-dev