[Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size
arapte at openjdk.java.net
Thu Jan 16 11:59:47 UTC 2020
On Thu, 16 Jan 2020 11:28:21 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
> The fix itself looks good and seems safe for 14.
> I do have few minor changes in test file and suggestions in fix code, please take a look.
> Also verified that large sized snapshots are created correctly.
> Upon closer inspection, I believe that the tests I added in Snapshot3Test are indeed redundant and less complete than the 4 ignored test in Snapshot2Test.
> I therefore propose to remove Snapshot3Test.java entirely and to re-enable the 4 testSnapshotBig* test instead.
I did miss this comment, The test in `Snapshot2Test` look sufficient and you can get rid of `Snapshot3Test.java` and so all my comments :)
More information about the openjfx-dev