[Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

Michael Paus mpaus at openjdk.java.net
Thu Jan 16 14:16:51 UTC 2020

On Thu, 16 Jan 2020 13:56:44 GMT, Frederic Thevenet <github.com+7450507+fthevenet at openjdk.org> wrote:

>> I think the proposed code changes are wrong in case that `height / maxTextureSize` is an exact integer. (Same for width). I normally add the 1 only if `height  % maxTextureSize != 0`
> Indeed, substituting the floating math for integer math requires an extra test on the remainder to be correct. 
> Since this code isn't located in a tight loop, I'm not sure this optimization is worth making the code less straight forward. What do you all think?

I think it is not worth it.


PR: https://git.openjdk.java.net/jfx/pull/68

More information about the openjfx-dev mailing list