[Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

Nir Lisker nlisker at openjdk.java.net
Fri Jan 17 19:25:06 UTC 2020

On Fri, 17 Jan 2020 19:22:24 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I'm not 100% convinced this would really add much to the readability of the code; I extracted the code from `doSnapshotTile` in its own method because it is called twice (on both sides of the `if (height > maxTextureSize || width > maxTextureSize)` condition, actually), but this isn't the case here.
>> I've got no strong feeling against it either, so I don't know; anybody else care to comment?
> I also don't have a strong opinion, so I'm OK with you leaving it as-is.

Fine to leave as-is.


PR: https://git.openjdk.java.net/jfx/pull/68

More information about the openjfx-dev mailing list