[Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed

Dean Wookey dwookey at openjdk.java.net
Wed Jan 22 16:26:10 UTC 2020

> Everything passes with the fix and 5 of the new tests fail without the fix.
> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
> movingBranchToDifferentBranchGetsNewCssVariableTest
> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue
> removingThenAddingNodeToDifferentBranchGetsIneritableStyle
> movingNodeToDifferentBranchGetsNewFontStyleTest
> I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is?
> Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab

The pull request has been updated with 1 additional commit.


Added commits:
 - 782f55e3: 8237469: Moved firstStyleableAncestor call to before canReuseStyleHelper can return true

  - all: https://git.openjdk.java.net/jfx/pull/87/files
  - new: https://git.openjdk.java.net/jfx/pull/87/files/0749dde7..782f55e3

 - full: https://webrevs.openjdk.java.net/jfx/87/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/87/webrev.00-01

  Stats: 5 lines in 1 file changed: 3 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/87.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/87/head:pull/87

PR: https://git.openjdk.java.net/jfx/pull/87

More information about the openjfx-dev mailing list