[Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed

David Grieve dgrieve at openjdk.java.net
Wed Jan 22 17:03:50 UTC 2020

On Wed, 22 Jan 2020 17:03:49 GMT, Dean Wookey <dwookey at openjdk.org> wrote:

>> Everything passes with the fix and 5 of the new tests fail without the fix.
>> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
>> movingBranchToDifferentBranchGetsNewCssVariableTest
>> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue
>> removingThenAddingNodeToDifferentBranchGetsIneritableStyle
>> movingNodeToDifferentBranchGetsNewFontStyleTest
>> I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is?
>> Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab
> The pull request has been updated with 1 additional commit.

Marked as reviewed by dgrieve (Reviewer).


PR: https://git.openjdk.java.net/jfx/pull/87

More information about the openjfx-dev mailing list