[Rev 02] RFR: 8236259: MemoryLeak in ProgressIndicator

Florian Kirmaier fkirmaier at openjdk.java.net
Mon Jan 27 15:34:46 UTC 2020

> Hi everyone,
> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
> The fix itself is quite straight forward.
> It basically just removed the listener which causes the leak.
> The unit-test for the fix is a bit more complicated.
> I added a library JMemoryBuddy https://github.com/Sandec/JMemoryBuddy (written by myself), which simplifies testing for memory leaks.
> I think there are many places in the JavaFX-codebase that could highly benefit from this library.
> It could also simplify many of the already existing unit tests.
> It makes testing for memory-leaks readably and reliable. 
> It would also be possible to just copy the code of the library into the JavaFX-codebase. 
> It only contains a single class.
> I also had to make a method public, to write the test. I'm open to ideas, how I could solve it differently.

The pull request has been updated with 1 additional commit.


Added commits:
 - 768f70c7: JDK-8236259

  - all: https://git.openjdk.java.net/jfx/pull/71/files
  - new: https://git.openjdk.java.net/jfx/pull/71/files/e9ea4d8e..768f70c7

 - full: https://webrevs.openjdk.java.net/jfx/71/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/71/webrev.01-02

  Stats: 30 lines in 3 files changed: 0 ins; 29 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/71.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/71/head:pull/71

PR: https://git.openjdk.java.net/jfx/pull/71

More information about the openjfx-dev mailing list