RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

Kevin Rushforth kcr at openjdk.java.net
Wed Jan 29 00:01:38 UTC 2020

On Tue, 28 Jan 2020 09:50:27 GMT, Guru Hb <ghb at openjdk.org> wrote:

> cl : Command line warning D9002 : ignoring unknown option '-m32'
> post fix for "https://trac.webkit.org/changeset/242724/webkit" makes use of cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. 
> '-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn't recognize this flag.

All my testing looks good. I added one comment for you to take a look at.

modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm line 2300:

> 2299: 
> 2300:     if (architecture() eq "x86_64" && shouldBuild32Bit() && (isJava() && !isCygwin())) {
> 2301:         # CMAKE_LIBRARY_ARCHITECTURE is needed to get the right .pc

This will work, since all we build is the Java platform, but I'm not sure that the `isJava()` test is quite right. It suggests that the logic should be skipped for other platforms (i.e., that the entire test and body of the if block is Java platform-specific), which it isn't. I think this should be:

    ... && !(isJava() && isCygwin())


PR: https://git.openjdk.java.net/jfx/pull/97

More information about the openjfx-dev mailing list