[Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

Guru Hb ghb at openjdk.java.net
Wed Jan 29 11:12:27 UTC 2020

On Tue, 28 Jan 2020 23:42:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm line 2300:
>> 2299: 
>> 2300:     if (architecture() eq "x86_64" && shouldBuild32Bit() && (isJava() && !isCygwin())) {
>> 2301:         # CMAKE_LIBRARY_ARCHITECTURE is needed to get the right .pc
> This will work, since all we build is the Java platform, but I'm not sure that the `isJava()` test is quite right. It suggests that the logic should be skipped for other platforms (i.e., that the entire test and body of the if block is Java platform-specific), which it isn't. I think this should be:
>     ... && !(isJava() && isCygwin())

You are correct, Current fix will block for all the other platform, Done the changes as suggested.


PR: https://git.openjdk.java.net/jfx/pull/97

More information about the openjfx-dev mailing list