[Rev 04] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size
kcr at openjdk.java.net
Wed Jan 29 19:10:22 UTC 2020
On Wed, 29 Jan 2020 19:10:22 GMT, Frederic Thevenet <github.com+7450507+fthevenet at openjdk.org> wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown from snapshot if dimensions are larger than max texture size
>> In order to do that, it simply captures snapshots in multiple tiles of maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the tiles into a a single image.
>> Other than that, the logic used to do the actual snapshot is unchanged.
>> Tests using the existing SnapshotCommon class have been added in a new file named Snapshot3Test under SystemTest/test/javafx/scene.
>> These tests pass with the proposed fix, and fail without, throwing " java.lang.IllegalArgumentException: Unrecognized image loader: null"
> The pull request has been updated with 1 additional commit.
I ran the additional test (test case 7 as described above) and it behaves the same with or without tiling, so no follow-up issue is needed.
Marked as reviewed by kcr (Lead).
More information about the openjfx-dev