[Rev 01] RFR: 8237770: Error creating fragment phong shader on iOS
jpereda at openjdk.java.net
Fri Jan 31 16:32:45 UTC 2020
On Fri, 31 Jan 2020 00:51:22 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
> modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/diffuse_color.frag line 32:
>> 31: #extension GL_OES_standard_derivatives : enable
>> 32: #define EXTENSION_APPLIED
>> 33: #endif
> Usual practice is to put the `#define` right after the `#ifndef`, but I don't have a strong opinion about that.
Makes sense, I've applied the change
More information about the openjfx-dev