RFR: 8202990: javafx webview css filter property with display scaling [v2]

Kevin Rushforth kcr at openjdk.java.net
Tue Sep 1 19:46:19 UTC 2020

On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary <bchoudhary at openjdk.org> wrote:

>> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due to which shadow was getting drawn on top of
>> actual image. apply given composite operator to graphics context before drawing image to fix this issue. another issue
>> is into WCGraphicsPrismContext.java. while blending two layers, applying state to the destination layer was missed due
>> to which image was not getting drawn with right scale in hidpi mode. apply state to fix the issue.
> Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision:
>   Moved test from unit test to system test

Looks good. I verified that the system test still catches the bug (that is, it fails without the fix and passes with
the fix). I ran it in a loop 100 times on both Mac and Windows without crashing.


Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/279

More information about the openjfx-dev mailing list