RFR: 8202990: javafx webview css filter property with display scaling [v2]

Arun Joseph ajoseph at openjdk.java.net
Wed Sep 2 03:30:49 UTC 2020

On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary <bchoudhary at openjdk.org> wrote:

>> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due to which shadow was getting drawn on top of
>> actual image. apply given composite operator to graphics context before drawing image to fix this issue. another issue
>> is into WCGraphicsPrismContext.java. while blending two layers, applying state to the destination layer was missed due
>> to which image was not getting drawn with right scale in hidpi mode. apply state to fix the issue.
> Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision:
>   Moved test from unit test to system test

tests/system/src/test/java/test/javafx/scene/web/CSSFilterTest.java line 93:

> 92:         double deltaOpacity = Math.abs(notExpected.getOpacity() - actual.getOpacity());
> 93:         if (deltaRed < delta && deltaGreen < delta && deltaBlue < delta && deltaOpacity < delta) {
> 94:             fail(msg + " not expected:" + colorToString(notExpected)

testColorEquals can be reused here.
`if (testColorEquals(expected, actual, delta))`


PR: https://git.openjdk.java.net/jfx/pull/279

More information about the openjfx-dev mailing list