RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v11]

Jeanette Winzenburg fastegal at openjdk.java.net
Fri Sep 11 10:20:41 UTC 2020

On Fri, 11 Sep 2020 09:41:46 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java line 1347:
>>> 1345:         final ComboBox<String> cb = new ComboBox<>(FXCollections.observableArrayList("a", "b", "c"));
>>> 1346:         cb.setEditable(true);
>>> 1347:         StageLoader sl = new StageLoader(cb);
>> shouldn't there be an analogous functional test for not-editable combo? There are both functional and low-level for
>> editable, but only low-level for not editable.
> I did not understand what low-level test mean here. But have added test for navigation keys which verify using
> `SelectionModel.getSelectedIndex()`. Please point if it is sufficient.

my apologies for having been unclear: low-level == implementation details in keyMappings whereas functional are those
testing the effect on firing keys.

But you guessed so much and added tests of key-firing on not-editable combo, so looks good now :)


PR: https://git.openjdk.java.net/jfx/pull/172

More information about the openjfx-dev mailing list