RFR: 8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec [v2]

Kevin Rushforth kcr at openjdk.java.net
Sat Sep 12 12:58:17 UTC 2020

On Sat, 12 Sep 2020 10:48:17 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Moving implementation details about lazy evaluation and equality checking to `@implSpec`.
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>   Addressed review comments

Looks good with one minor comment. Go ahead and create the CSR once you make the requested update.

modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java line 46:

> 44:  * An {@code ObservableValue} generates two types of events: change events and
> 45:  * invalidation events. A change event indicates that the value has changed
> 46:  * (see note 2 in "Implementation Requirements"). An invalidation event is generated if the current value is not
> valid anymore.

Minor: either add `the` before `"Implementation Requirements"` here or remove `the` from the earlier line for

Minor: as long as you are here, can you break this line between `An` and `invalidation`? In addition to wrapping a long
line, it will reduce the diffs, which seems good given that there will be an associated CSR.


PR: https://git.openjdk.java.net/jfx/pull/292

More information about the openjfx-dev mailing list