RFR: 8252236: TabPane: must keep header of selected tab visible [v2]

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Sep 24 13:10:41 UTC 2020

On Thu, 24 Sep 2020 07:08:55 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> good eye :) Forgot to remove the empty else block.
>> Validate must be called always if the tabs are not fitting: needed if the last tab (in the list) is visible and we
>> remove tabs from the end. Without, the now last tab is not kept glued to the trailing edge. There are two tests
>> covering the corner case (testRemoveXXLast) which fail if we don't.  Question is if that should be mentioned in a code
>> comment? Personally, I tend to just delete the empty block.
> Thanks, I confirmed that it is a needed change. I think, a comment will be useful here, as the problem that is solved
> by this change is not very vivid from source.

added a comment to clarify what the validate is doing


PR: https://git.openjdk.java.net/jfx/pull/300

More information about the openjfx-dev mailing list