RFR: 8251946: ObservableList.setAll does not conform to specification [v2]
github.com+4029915+TheMrMilchmann at openjdk.java.net
Fri Sep 25 10:26:53 UTC 2020
On Thu, 24 Sep 2020 18:23:54 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Leon Linhart has updated the pull request incrementally with one additional commit since the last revision:
>> Removed unused import and addressed review comments
> modules/javafx.base/src/main/java/javafx/collections/ModifiableObservableListBase.java line 32:
>> 30: import java.util.List;
>> 31: import java.util.ListIterator;
>> 32: import java.util.Objects;
> This import seems unused, please remove.
Indeed. Removed it.
> modules/javafx.base/src/main/java/javafx/collections/ModifiableObservableListBase.java line 97:
>> 95: clear();
>> 96: addAll(col);
>> 97: return true;
> I think following code would be more suitable here,
> boolean res = super.addAll(c);
> return res;
> This code is already used in two `addAll()` methods of this class.
Makes sense to me. I changed it accordingly.
More information about the openjfx-dev