RFR: 8269081: Tree/ListViewSkin: must remove flow on dispose
arapte at openjdk.java.net
Thu Sep 2 09:20:40 UTC 2021
On Fri, 27 Aug 2021 11:15:58 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
> left-over issue from cleanup of Tree/ListViewSkin: direct children that have been added by the skin must be removed in dispose
> fixed by removing the flow (which allowed to revert the previous cleanup of event handlers/cellfactory)
> added tests to verify
> - constant child count after replacing skin
> - no memory leak when switching skin while showing
Looks good to me.
Marked as reviewed by arapte (Reviewer).
More information about the openjfx-dev