RFR: 8172095: Let Node.managed become CSS-styleable
kcr at openjdk.java.net
Fri Sep 3 21:52:51 UTC 2021
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal <github.com+3197675+abhinayagarwal at openjdk.org> wrote:
> 8172095: Let Node.managed become CSS-styleable
The new API looks fine. I left one comment on the cssref docs, and that's otherwise ready to go (so you can get the CSR ready).
I noticed that there are no existing tests in `NodeTest` for the default value or for setting / getting the property, which there are for other properties. Can you add these missing tests, to verify that there are no problems?
modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 1755:
> 1753: <tr>
> 1754: <th class="propertyname" scope="row">-fx-managed</th>
> 1755: <td class="value"><a href="#typeboolean" class="typelink"><boolean></a></td>
This isn't rendered correctly. You need to use `<boolean>`.
More information about the openjfx-dev