RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

Jose Pereda jpereda at openjdk.java.net
Mon Sep 6 15:08:42 UTC 2021

On Mon, 6 Sep 2021 13:30:46 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>>   Use color to int32 converter instead of hash
>> The other option, as you mention, is finding out if the 32-bit int has alpha 0 or 1, which can be done storing only the int value, not the color, so this looks cleaner, we don't really need to hold a reference to the Color after all
> Yes, I like this better, too.
> I also agree with the point about including `rgba` in the name. It is also meaningful to keep `int` in the name. We would typically call this format `IntRgba`.

@kevinrushforth In case you didn't see it, I replied to your comment https://github.com/openjdk/jfx/pull/563#discussion_r702164954 here: https://github.com/openjdk/jfx/pull/563/files#r702814752 (but there was not email notification).


PR: https://git.openjdk.java.net/jfx/pull/563

More information about the openjfx-dev mailing list