RFR: 8172095: Let Node.managed become CSS-styleable [v2]

Ambarish Rapte arapte at openjdk.java.net
Thu Sep 9 08:19:04 UTC 2021

On Sat, 4 Sep 2021 15:44:17 GMT, Abhinay Agarwal <github.com+3197675+abhinayagarwal at openjdk.org> wrote:

>> 8172095: Let Node.managed become CSS-styleable
> Abhinay Agarwal has updated the pull request incrementally with two additional commits since the last revision:
>  - Add default value tests for setting / getting the managed property
>  - Replace with HTML equivalent code

Changes look good to me. 
The tests, managedSetFromCSS() and Node_cssMethods_Test fail before and pass after. Other tests do pass both before and after, which is expected behaviour.


Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/602

More information about the openjfx-dev mailing list