RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v3]
fkirmaier at openjdk.java.net
Mon Sep 13 14:38:20 UTC 2021
On Mon, 13 Sep 2021 13:35:52 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are added to the ticket.
>> Removing the nested loop fixes the Problem.
>> I hope this doesn't have any side effect - so far i don't know of any.
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> Removed the enter/leave nested event loop logic, for mac fullscreen
I've now added a unit test.
I've adapted the solution to entirely remove the nested event loop, for the fullscreen. So far everything seems to work.
I've tested it with a simple application to check how the fullscreen behaves.
The logic seems to be added before the beginning of the VCS / 2013
Is there away to look into the history before 2013? Maybe there is a hint, why this was added.
Otherwise i would guess that it is not too important, and it is just an unnecessary overcomplicated solution.
More information about the openjfx-dev