RFR: 8272870: Add convenience factory methods for border and background [v3]

Ambarish Rapte arapte at openjdk.java.net
Wed Sep 15 11:19:51 UTC 2021

On Wed, 15 Sep 2021 11:03:20 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with two additional commits since the last revision:
>>  - Removed whitespaces
>>  - Added tests and doc updates
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java line 357:
>> 355: 
>> 356:     /**
>> 357:      * A convenience factory method for creating a background with a single {@code Paint}.
> Minor: typo:  `background` -> `Background`
> Let's use the `Background` in all places where we refer the class name. Two other places which need similar change are in @param and @return
> A similar change is needed for Border.stroke method also: border -> Border

Another suggestion for the description, inspired from the constructors of this class:
`A convenience factory method to create a new Background by supplying a single {@code Paint}.`

I am good with the current statement too. Above one will just be uniform with existing doc. I leave it to your choice.


PR: https://git.openjdk.java.net/jfx/pull/610

More information about the openjfx-dev mailing list