RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

Kevin Rushforth kcr at openjdk.java.net
Wed Sep 22 15:22:56 UTC 2021

On Wed, 22 Sep 2021 13:59:43 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> > We added `@SuppressWarnings("removal")` annotations for JDK-8264139, so I'm surprised the IDE is still flagging it.
> The warning is on the `import` of the class, which can be suppressed by adding the annotation to the class declaration. Maybe it's only this way in the Eclipse compiler.

This sounds like an Eclipse problem then. In any case, I would not consider adding annotations to the classes. We went to some effort to make the scope of the annotations as local as possible (as did the JDK).

> > We could consider a follow-up issue to clean this up, but I'm not really inclined to change anything.
> The question is if this can cause any bugs? Is the method supposed to override? If yes and it isn't, it sounds like something could go wrong.

It isn't intended to be an override. The context parameter is passed up to the superclass and stored there as well as in the subclass. We could explore a different design pattern, but I don't think it is necessary.


PR: https://git.openjdk.java.net/jfx/pull/628

More information about the openjfx-dev mailing list