RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v3]

John Hendrikx jhendrikx at openjdk.java.net
Sat Sep 25 13:27:49 UTC 2021

On Sat, 25 Sep 2021 13:13:03 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> The gradle verification task failed (see the test results from GitHub Actiona). It looks like it still needs the hamcrest jars. Go ahead and add them back in (and remove the exclusion for them).

Yeah, I noticed, I couldn't get rid of them.  Apparently JUnit 4 itself is depending on them now (starting from 4.10 orso) and the Vintage engine requires JUnit 4.12+, so it is actually overriding JUnit 4.8.2 to 4.13.2 and pulls in the Hamcrest jars again.

I've tried forcing JUnit to 4.8.2 and even though that works, it leads to a spam stacktrace in the logs for each test executed because it can't find something via reflection.  I then tried to hide this log message, but have been unable to find any way of getting that message blocked by configuring java.util.logging that works in combination with Gradle and its daemon.

So... I've sort of think this is not a fight we can win easily and have reincluded the Hamcrest jars.  I also removed the JUnit 4 dependency as the Vintage engine will pull a newer one in any way.

I think I should upgrade these lines as well: `testImplementation group: "junit", name: "junit", version: "4.8.2"` in each of the modules to make it clear 4.13.2 is used and not 4.8.2.


PR: https://git.openjdk.java.net/jfx/pull/633

More information about the openjfx-dev mailing list