RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v4]
fkirmaier at openjdk.java.net
Tue Sep 28 10:05:03 UTC 2021
On Fri, 17 Sep 2021 12:51:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> small cleanup of the changes.
> You can also see the exception with _any_ JavaFX program: enter full-screen with the green button, move the mouse to the upper-left corner to reveal the window decorations, and press the red button to exit the program.
> I think you need to look for a different solution to your deadlock, one that preserves the existing nested event loop.
Did you test really test my change and was able to reproduce the JDK-8126842 with it?
On my system everything works - except the small "beep" sound.
After investigating it, I've made another small change - which fixes the beep sound. It also makes it closer to the implementation for iOS. I've changed the `waitUntilDone` value to true, when closing the window.
I think removing the nestedEventLoops should be preferred over another fix - in my experience the nested event loops are the cause of so many rare and very complicated bugs.
More information about the openjfx-dev